fix(burushos.bsk-latn.burushaski): make name consistent and apply version number #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion number Fixes: #297
mcdurdin
commented
Jan 29, 2025
There was a problem hiding this comment.
.model_info files should no longer be committed to the repository
darcywong00
reviewed
Jan 29, 2025
| @@ -20,12 +20,12 @@ | |||
| <Name URL="">Burushaski</Name> | |||
| <Copyright URL="">Copyright © Burusho</Copyright> | |||
| <Author URL="">Burusho</Author> | |||
There was a problem hiding this comment.
Maybe more sadness.
If the author name is "Burusho", should the parent folder change from "burushos" to "burusho"? And then changing the other model (burushos.bsk.burushaski) to match?
There was a problem hiding this comment.
I opted to match the existing model which has already been widely deployed. It's much messier to go the other way, and not worth the pain IMHO.
mcdurdin
deleted the
fix/297-burushos.bsk-latn.burushaski-id-and-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #297