Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more project layout improvements #12

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

igor-sirotin
Copy link
Collaborator

I've done these changes as part of working at the new API, but providing this as separate PR, as it's not technically related to the new code.

  1. Remove non-needed go.mod files from examples.
  2. Upgraded requirements to Go 1.22
  3. Extracted constants to internal/const.go
  4. Extracted HexString and conversion funcs type to ./pkg/utils
  5. Extracted a pairing package with common functionality
  6. Moved Flow API func from main.go to api_flow.go. The new API will be in a separate file.
  7. Extracted mnemonicToBinarySeed function

Copy link
Collaborator

@bitgamma bitgamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please rebase to current master

@igor-sirotin igor-sirotin force-pushed the chore/project-layout-2 branch from df6ebee to 6f1e4b2 Compare January 20, 2025 10:52
@igor-sirotin igor-sirotin merged commit 6e63788 into master Jan 20, 2025
5 checks passed
@igor-sirotin igor-sirotin deleted the chore/project-layout-2 branch January 20, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants