-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New plugins Arrow Flight and Dremio #169
New plugins Arrow Flight and Dremio #169
Conversation
closes kestra-io/kestra#1854 split plugins from #162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is missing tests for Query and Trigger tasks.
In your test, please create a table with multiple row types (as done in other JDBC plugins) to check that the CellConverter didn't need to handle type conversions.
plugin-jdbc-arrow-flight/src/main/java/io/kestra/plugin/jdbc/arrowflight/Query.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-arrow-flight/src/main/java/io/kestra/plugin/jdbc/arrowflight/Query.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-arrow-flight/src/main/java/io/kestra/plugin/jdbc/arrowflight/Query.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-arrow-flight/src/main/java/io/kestra/plugin/jdbc/arrowflight/Trigger.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-dremio/src/main/java/io/kestra/plugin/jdbc/dremio/Query.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-dremio/src/main/java/io/kestra/plugin/jdbc/dremio/Trigger.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-arrow-flight/src/main/java/io/kestra/plugin/jdbc/arrowflight/package-info.java
Outdated
Show resolved
Hide resolved
@iNikitaGricenko could you update the PR body with an Arrow Flight example that worked for you with a Dremio Test Drive account? |
@anna-geller, databases that are given into Dremio Test Drive does not support apache arrow flight |
I'm sorry, I didn't know that. |
Co-authored-by: Loïc Mathieu <loikeseke@gmail.com>
…rrowflight/package-info.java Co-authored-by: Loïc Mathieu <loikeseke@gmail.com>
What changes are being made and why?
Added Dremio jdbc plugin and Apache Arrow Flight. Splited both plugins as separated plugins
How the changes have been QAed?
Trough Dremio test drive and Dremio account
Setup Instructions