netkit: Allow for configuring needed_{head,tail}room #8281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 8eef6ac |
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=919577 expired. Closing PR. |
|
Upstream branch: c5d2bac |
kernel-patches-daemon-bpf
bot
added
new
V2
and removed
changes-requested
V1
V1-ci-pass
labels
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
8dfb348 to
43e7fce
Compare
|
Upstream branch: c5d2bac |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
43e7fce to
5c15a20
Compare
|
Upstream branch: c5d2bac |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
5c15a20 to
4435ea9
Compare
|
Upstream branch: c5d2bac |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
4435ea9 to
1d8d52a
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
2 times, most recently
from
0cdd956 to
b0c73ce
Compare
|
Upstream branch: c5d2bac |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
1d8d52a to
94aaf15
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b0c73ce to
e1e6b38
Compare
|
Upstream branch: 4a24035 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
94aaf15 to
66b73f1
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e1e6b38 to
aee9254
Compare
|
Upstream branch: 654a338 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
66b73f1 to
7f84353
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
aee9254 to
da86bde
Compare
|
Upstream branch: dfa94ce |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
7f84353 to
2d766d0
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
da86bde to
2db328a
Compare
Allow the user to configure needed_{head,tail}room for both netkit
devices. The idea is similar to 163e529 ("veth: implement
ndo_set_rx_headroom") with the difference that the two parameters
can be specified upon device creation. By default the current behavior
stays as is which is needed_{head,tail}room is 0.
In case of Cilium, for example, the netkit devices are not enslaved
into a bridge or openvswitch device (rather, BPF-based redirection
is used out of tcx), and as such these parameters are not propagated
into the Pod's netns via peer device.
Given Cilium can run in vxlan/geneve tunneling mode (needed_headroom)
and/or be used in combination with WireGuard (needed_{head,tail}room),
allow the Cilium CNI plugin to specify these two upon netkit device
creation.
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Nikolay Aleksandrov <razor@blackwall.org>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Add netkit {head,tail}room attribute support to the rt_link.yaml spec file.
Example:
# ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/rt_link.yaml \
--do getlink --json '{"ifname": "nk0"}' --output-json | jq
[...]
"linkinfo": {
"kind": "netkit",
"data": {
"primary": 0,
"policy": "forward",
"mode": "l3",
"scrub": "default",
"headroom": 0,
"tailroom": 0,
"peer-policy": "forward",
"peer-scrub": "default"
}
},
[...]
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Nikolay Aleksandrov <razor@blackwall.org>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Extend the netkit selftests to specify and validate the {head,tail}room
on the netdevice:
# ./vmtest.sh -- ./test_progs -t netkit
[...]
./test_progs -t netkit
[ 1.174147] bpf_testmod: loading out-of-tree module taints kernel.
[ 1.174585] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel
[ 1.422307] tsc: Refined TSC clocksource calibration: 3407.983 MHz
[ 1.424511] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x311fc3e5084, max_idle_ns: 440795359833 ns
[ 1.428092] clocksource: Switched to clocksource tsc
#363 tc_netkit_basic:OK
#364 tc_netkit_device:OK
#365 tc_netkit_multi_links:OK
#366 tc_netkit_multi_opts:OK
#367 tc_netkit_neigh_links:OK
#368 tc_netkit_pkt_type:OK
#369 tc_netkit_scrub:OK
Summary: 7/0 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Nikolay Aleksandrov <razor@blackwall.org>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
|
Upstream branch: 96ea081 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/919577=>bpf-next
branch
from
2d766d0 to
742a11d
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=919577 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: netkit: Allow for configuring needed_{head,tail}room
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=919577