-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managing model specializations/variants (flavors) #1151
Open
kermitt2
wants to merge
12
commits into
master
Choose a base branch
from
flavor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! I'm going to test it directly in the branch for the light-segmentation models :-) and feedback changes |
Here an updated figure showing the mechanism, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a simple management of alternative models to use when processing a document. A model variant is for example a alternative header model trained with its own training data and labels (to cover documents with specific header section different from scholar articles), or an alternative segmentation model for segmenting something else than scholar papers.
To process a document with alternative model(s), we use a string called "flavor" to identify it. If the flavor is indicated, the selected model will use the "flavor" model if it exists, and the normal model if the flavor does exist for this model (so defaulting back then to the standard models).
Flavor model training data are always located as sub-directory of the standard training data path, e.g. for the flavor "sdo/ietf", the training data of the header model for this flavor will be under
grobid-trainer/resources/dataset/header/sdo/ietf
. The training data of the segmentation model for this flavor will be undergrobid-trainer/resources/dataset/segmentation/sdo/ietf
, and so on.For running grobid following a particular flavor, we add the flavor name as additional parameter of the service:
Grobid will then solve the right models to use given the Grobid model hierarchy/cascade: the flavor ones if they exist, or the default ones if not.
In this branch, "sdo/ietf" flavor is just used as an example, the corresponding flavor models are not actually really working.