Fix memory leaks in model.evaluate.
#20779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The history is only used in `model.fit`, no need to create it for `evaluate` and `predict`. The history is attached to the model and therefore lives for as long as the model is around. The executor used in `CallbackList` was never shut down, causing it to keep a thread around, which in turn had thread locals that were leaked.
fchollet
approved these changes
Jan 17, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20779 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 555 555
Lines 51817 51820 +3
Branches 8016 8017 +1
=======================================
+ Hits 42486 42489 +3
Misses 7379 7379
Partials 1952 1952
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
google-ml-butler
bot
removed
the
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The history is only used in
model.fit, no need to create it forevaluateandpredict. The history is attached to the model and therefore lives for as long as the model is around.The executor used in
CallbackListwas never shut down, causing it to keep a thread around, which in turn had thread locals that were leaked.