Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #20616 #20683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion keras/src/ops/numpy.py
Original file line number Diff line number Diff line change
Expand Up @@ -6522,7 +6522,14 @@ def eye(N, M=None, k=0, dtype=None):

Returns:
Tensor with ones on the k-th diagonal and zeros elsewhere.
"""
Raises:
Error if N, M are not integer values.
"""
if not isinstance(N, int):
raise ValueError(f"N must be an integer, got {type(N).__name__}")
if M is not None and not isinstance(M, int):
raise ValueError(f"M must be an integer, got {type(M).__name__}")

return backend.numpy.eye(N, M=M, k=k, dtype=dtype)


Expand Down
2 changes: 2 additions & 0 deletions keras/src/ops/numpy_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -4718,6 +4718,8 @@ def test_eye(self):
# Test k < 0 and M < N and M - k > N
self.assertAllClose(knp.Eye(k=-2)(4, 3), np.eye(4, 3, k=-2))



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove added blank lines

def test_arange(self):
self.assertAllClose(knp.arange(3), np.arange(3))
self.assertAllClose(knp.arange(3, 7), np.arange(3, 7))
Expand Down
Loading