Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox/X icon bad height when itemHeight is used. (and some misc feedback) #127

Open
jorgemmsilva opened this issue Jan 24, 2019 · 0 comments

Comments

@jorgemmsilva
Copy link
Contributor

First of all, thanks for the work on this library - the component is quite cool.

Expected Behavior

Checkboxes and "remove icons" should resize according to itemHeight prop.

Actual Behavior

screenshot 2019-01-24 at 18 03 03

screenshot 2019-01-24 at 18 50 28

Checkboxes do not obey the itemHeight value - leading to wrong selections when clicked.
(the same applies to the 'x' icon on the selected items)
This is fixable by css with something like this:

  div[aria-label="grid"]>div {
    div>div>span {
      height: 20px;
    }
  }

But it's an hack. The lib should handle this.

Steps to Reproduce the Problem

  1. set the itemHeight prop to something less than 40px

Other feedback:

  • better styles customisation - allow custom classes for listItems (or even better use https://emotion.sh/ )
  • allow a selector for the Id of each item (which imo should be called value) - having a getId prop that receives a function

Neat Features:

  • "Select/Deselect All" checkbox for each group

^ I might create a PR for some of that in the future if I get the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant