Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogFontScalar has incorrect calculations #75

Open
faseidl opened this issue Dec 10, 2018 · 2 comments
Open

LogFontScalar has incorrect calculations #75

faseidl opened this issue Dec 10, 2018 · 2 comments

Comments

@faseidl
Copy link

faseidl commented Dec 10, 2018

The calculation of leftSpan uses Math.sqrt() but should use Math.log().
@faseidl
Copy link
Author

faseidl commented Dec 10, 2018

Also, when minValue is zero (as it is passed in from WordCloud.buildWord()), the calculation of scaledValue1 attempts to evaluate Math.log(0), which is undefined.

@faseidl faseidl changed the title LogFontScalar has incorrect calculation of leftSpan LogFontScalar has incorrect calculations Dec 10, 2018
@kennycason
Copy link
Owner

good catch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faseidl @kennycason