use normal(0,1) to generate the orthogonal matrix

Signed-off-by: Keming <kemingy94@gmail.com>
kemingy · Sep 25, 2024 · e4f1ec3 · e4f1ec3
1 parent 8001d3f
commit e4f1ec3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -16,6 +16,7 @@ faer = "0.19"
 log = "0.4"
 num-traits = "0.2"
 rand = "0.8"
+rand_distr = "0.4.3"
 serde = "1"
 serde_json = "1"
 

diff --git a/src/utils.rs b/src/utils.rs
@@ -7,14 +7,14 @@ use std::path::Path;
 use faer::{Col, ColRef, Mat, MatRef};
 use num_traits::{FromBytes, ToBytes};
 use rand::distributions::{Distribution, Uniform};
+use rand_distr::StandardNormal;
 
 use crate::consts::THETA_LOG_DIM;
 
 /// Generate a random orthogonal matrix from QR decomposition.
 pub fn gen_random_qr_orthogonal(dim: usize) -> Mat<f32> {
     let mut rng = rand::thread_rng();
-    let uniform = Uniform::<f32>::new(0.0, 1.0);
-    let random = Mat::from_fn(dim, dim, |_, _| uniform.sample(&mut rng));
+    let random: Mat<f32> = Mat::from_fn(dim, dim, |_, _| StandardNormal.sample(&mut rng));
     random.qr().compute_q()
 }