Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.6.2 - bug fixes #68

Merged
merged 30 commits into from
Feb 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
42ebdbf
feat: scan X newly acquired relics
kel-z Feb 10, 2024
079a75c
style: format
kel-z Feb 10, 2024
e48b34e
fix: parsing duplicate character name during scan
kel-z Feb 10, 2024
aaa58e2
style: misc
kel-z Feb 10, 2024
6a3c5e1
feat: add uid and trailblazer to output
kel-z Feb 11, 2024
53f4119
Merge branch 'main' of https://github.com/kel-z/HSR-Scanner into dev
kel-z Feb 11, 2024
c11bfcd
style: qtcore import
kel-z Feb 11, 2024
4dc9d85
fix: scan trailblazer case #49
kel-z Feb 11, 2024
c6c4d72
fix: line
kel-z Feb 11, 2024
c773f62
fix: more char name fixes
kel-z Feb 11, 2024
64877ce
fix: bruh
kel-z Feb 11, 2024
03966ee
fix: oops
kel-z Feb 13, 2024
6cb2a34
fix: handle TB when name is still prev character #49
kel-z Feb 13, 2024
263a040
style: tab name Extra -> Advanced
kel-z Feb 13, 2024
82c59f9
feat: support more key bindings #67
kel-z Feb 15, 2024
c3cd4b5
feat: databank parse retry
kel-z Feb 15, 2024
ce59041
docs: add step for setting language to en
kel-z Feb 18, 2024
2a3a109
refactor: scan left to right for last char page
kel-z Feb 21, 2024
c1b1635
feat: save log to disk in debug mode
kel-z Feb 21, 2024
18bd9c9
refactor: logs
kel-z Feb 21, 2024
c2a5cc2
feat: retry quantity parse + more interrupt
kel-z Feb 22, 2024
7f0fb5a
fix: misc bugs
kel-z Feb 22, 2024
9eeed80
fix: move ascension check after name parse
kel-z Feb 22, 2024
30abd1b
feat: increase sensitivity of substat preprocessing
kel-z Feb 22, 2024
17e8c39
feat: truncate uid
kel-z Feb 22, 2024
ac57b6f
feat: add guards for rare parse errors
kel-z Feb 23, 2024
c0c5f2d
fix: revert substat sensitivity + remove double periods
kel-z Feb 23, 2024
77a4db7
revert: hide advanced tab for now
kel-z Feb 23, 2024
a3787cb
feat: force scroll down on new log message
kel-z Feb 23, 2024
4f5c4e1
feat: add build key to output
kel-z Feb 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ The resulting output can be used in various community-made optimization tools in

## Instructions

1. Set in-game resolution to one that has an aspect ratio of 16:9 (e.g. 1920x1080, 1280x720).
2. **In Star Rail, look away from any bright colours.** _Yes, really._ The inventory screen is translucent and bright colours can bleed through to make the text harder to accurately detect and recognize. Looking towards the ground usually works in most cases, as long as the right side of the screen is relatively dark. (Double-check by opening the inventory page and see if the item info on the right contrasts well with the background.) You can skip this step if you're only scanning characters.
![Dark background example](./example.png)
3. Open the cellphone menu (ESC menu).
4. Configure the necessary [scanner settings](#scanner-settings-and-configurations) in HSR Scanner.
5. Start the scan.
6. Do not move your mouse during the scan process.
7. Once the scan is complete, some additional time may be required to process the data before generating the final JSON file output.
1. Set text language to English.
2. Set in-game resolution to one that has an aspect ratio of 16:9 (e.g. 1920x1080, 1280x720).
3. **In Star Rail, look away from any bright colours.** _Yes, really._ The inventory screen is translucent and bright colours can bleed through to make the text harder to accurately detect and recognize. Looking towards the ground usually works in most cases, as long as the right side of the screen is relatively dark. (Double-check by opening the inventory page and see if the item info on the right contrasts well with the background.) You can skip this step if you're only scanning characters.
![Dark background example](./example.png)
4. Open the cellphone menu (ESC menu).
5. Configure the necessary [scanner settings](#scanner-settings-and-configurations) in HSR Scanner.
6. Start the scan.
7. Do not move your mouse during the scan process.
8. Once the scan is complete, some additional time may be required to process the data before generating the final JSON file output.

As of `v0.3.0`, the app's database is [updated separately](https://github.com/kel-z/HSR-Data) from this repo. If the database version doesn't match the latest game version, then the database hasn't been updated yet.

Expand All @@ -35,6 +36,7 @@ HSR Scanner has the following scan options:
- Filter light cones and relics based on a minimum rarity or level threshhold.

For slower systems, the scanner might perform its inputs too fast for the game to respond or render in time. To work around this, there are two types of delays that can be increased in the configure tab:

- Navigation delay for navigating between different pages (inventory, character details, etc.)
- Scan delay for clicking between individual items (relics, light cones, and characters).

Expand All @@ -49,6 +51,8 @@ The output is loosely based off of Genshin's `.GOOD` export format. I don't expe
### Notes

- SPD substats have a hidden decimal place that the scanner cannot directly parse. As a result, reproducing your character's stats (such as on optimizer websites) will most likely have a lower SPD stat than what it displays in-game. This is not an issue with the scanner, but rather a limitation when obtaining substats through OCR.
- UID will not be included by default. This can be changed in the configure tab.
- If the Trailblazer variant cannot be determined during the scan, it will default to `Stelle`.
- Flat substats and percentage substats are differentiated by an underscore suffix in the key.
- Main stats will never have an underscore suffix.
- The `_id` value for light cones and relics is arbitrarily assigned during the scanning process. It is intended for easy lookup in case of any errors logged during the scan, for double-checking or manual correction purposes.
Expand All @@ -63,7 +67,12 @@ Current output sample:
```JSON
{
"source": "HSR-Scanner",
"build": "v0.6.2",
"version": 3,
"metadata": {
"uid": 601869216,
"trailblazer": "Stelle"
},
"light_cones": [
{
"key": "Cruising in the Stellar Sea",
Expand Down
Loading