Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use crate once_cell instead of std::cell #468

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use crate once_cell instead of std::cell #468

wants to merge 7 commits into from

Conversation

notlesh
Copy link
Collaborator

@notlesh notlesh commented Feb 4, 2025

This PR avoids the need for a nightly rust compiler by avoiding the once_cell_try feature. This is accomplished by using the once_cell crate instead of std::cell.

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testingx

Breaking changes?

  • yes
  • no

@notlesh notlesh requested a review from HermanObst as a code owner February 4, 2025 21:18
@notlesh notlesh mentioned this pull request Feb 4, 2025
Open
whichqua
whichqua approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@whichqua whichqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whichqua whichqua whichqua approved these changes

@HermanObst HermanObst Awaiting requested review from HermanObst HermanObst is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notlesh @whichqua