Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: alexandria build requires specific commit hashes #343

Open
ccbbccbb opened this issue Dec 19, 2024 · 3 comments
Open

bug: alexandria build requires specific commit hashes #343

ccbbccbb opened this issue Dec 19, 2024 · 3 comments

Comments

@ccbbccbb
Copy link

Bug Report

Alexandria version:

commit hash: 6a989d636243494a0529fc3af06a924493499564

Current behavior:

note that this is specific to dojo as it defaults to using 2.8.4 -- when building with sozo (sozo build), alexandria only works with specific commit hash to resolve dependencies. without specifying a hash (e.g. relying on the default branch or rev-less spec), the build fails with a starknet version mismatch:

❯ sozo build
    Updating git repository https://github.com/keep-starknet-strange/alexandria
error: Version solving failed:
- alexandria_bytes v0.1.0 
(git+https://github.com/keep-starknet-strange/alexandria.git#162bed1c636d31ccaaa90ed3eb32c9eb1d5e3bd3) 
cannot use starknet v2.8.4 (std), because alexandria_bytes requires starknet ^2.9.2

Scarb does not have real version solving algorithm yet.
Perhaps in the future this conflict could be resolved, but currently,
please upgrade your dependencies to use latest versions of their dependencies.

Expected behavior:

simplify dependency management by removing the need to specify commit hashes.

Steps to reproduce:

  1. add the following to scarb.toml:
alexandria_data_structures = { git = "https://github.com/keep-starknet-strange/alexandria.git" }
  1. run sozo build w/ sozo 1.0.8.
  2. observe error.
  3. alternatively, explicitly include a commit hash to get the build working:
alexandria_data_structures = { git = "https://github.com/keep-starknet-strange/alexandria.git", rev = "6a989d636243494a0529fc3af06a924493499564" }

this works but is not ideal.

Related code:

specified above.

Other information:

updating release tags for the repository aligned with starknet versions (e.g., v2.8.4 or v2.9.2) would help.

example of how this could be done:

alexandria_data_structures = { 
git = "https://github.com/keep-starknet-strange/alexandria.git", 
tag = "v2.8.4"
}
@gaetbout
Copy link
Collaborator

I think @0xLucqs, this one is for you

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale No activity for quite some time. label Jan 20, 2025
@gaetbout
Copy link
Collaborator

@0xLucqs ?

@gaetbout gaetbout reopened this Jan 27, 2025
@github-actions github-actions bot removed the stale No activity for quite some time. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants