Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document existing WebhookConfiguration admission behaviour #3294

Open
embik opened this issue Feb 11, 2025 · 0 comments
Open

chore: document existing WebhookConfiguration admission behaviour #3294

embik opened this issue Feb 11, 2025 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@embik
Copy link
Member

embik commented Feb 11, 2025

We have a kcp-secific admission plugin validatingwebhook (and one for mutating webhooks as well), but I cannot find any documentation on it. We should make sure we document how ValidatingWebhookConfigurations and MutatingWebhookConfigurations work in kcp.

My understanding of a quick code scan is that the plugin finds the source of an API (i.e. where its APIExport lives) and calls webhooks configured in that workspace.

Whoever picks this ticket up has to confirm this behaviour (e.g. what happens to ValidatingWebhookConfigurations in the workspace of the APIBinding that backs an object) and write a small documentation / tutorial page to be published in our docs folder.

Please add an e2e test case as well to make sure we don't break this behaviour in the future.

@embik embik added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 11, 2025
@kcp-ci-bot kcp-ci-bot added this to kcp Feb 11, 2025
@github-project-automation github-project-automation bot moved this to New in kcp Feb 11, 2025
@embik embik changed the title chore: document existing ValidatingWebhookConfiguration admission behaviour chore: document existing WebhookConfiguration admission behaviour Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
Status: New
Development

No branches or pull requests

1 participant