Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kind to local scope #971

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jan 3, 2024

Add kind to local scope and use to distinguish different scope types. It is also used to distinguish l/r values in schema expr to provide more accurate completion in lsp.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/mod.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add kind to local scope and use to distinguish different scope types. It is also used to distinguish l/r values in schema expr to provide more accurate completion in lsp.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…tinguish different scope types. It is also used to distinguish lvalues and rvalues in schema expr to provide more accurate completion in lsp.

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added lsp resolver semantic Issues or PRs related to kcl semantic and checker labels Jan 3, 2024
@He1pa He1pa added this to the v0.8.0 Release milestone Jan 3, 2024
@He1pa He1pa linked an issue Jan 3, 2024 that may be closed by this pull request
10 tasks
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7398178525

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.787%

Totals Coverage Status
Change from base Build 7382979999: 0.0%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy self-requested a review January 4, 2024 03:02
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the local_scope_kind branch from 68392b4 to 566cd3c Compare January 4, 2024 06:46
@Peefy Peefy merged commit a8e78c1 into kcl-lang:main Jan 4, 2024
9 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp resolver semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][track]More IDE completion support on kcl attribute/parameters
3 participants