Skip to content

feat: add net.CIDR_subnet function #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Conversation

johngmyers
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1857

2. What is the scope of this PR (e.g. component or file name):

kclvm/runtine/src/net

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Adds a function to allocate a network out of a CIDR.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@johngmyers johngmyers force-pushed the cidrsubnet branch 7 times, most recently from c433452 to 4738d27 Compare April 12, 2025 03:43
@johngmyers johngmyers changed the title feat: add net.cidr_subnet function feat: add net.CIDR_subnet function Apr 12, 2025
@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2025

Pull Request Test Coverage Report for Build 14416694431

Details

  • 147 of 217 (67.74%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.462%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/net/mod.rs 146 216 67.59%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 84.97%
kclvm/tools/src/LSP/src/state.rs 12 72.41%
Totals Coverage Status
Change from base Build 14338841824: -0.02%
Covered Lines: 53263
Relevant Lines: 75591

💛 - Coveralls

Signed-off-by: John Gardiner Myers <jgmyers@proofpoint.com>
Signed-off-by: John Gardiner Myers <jgmyers@proofpoint.com>
@johngmyers johngmyers marked this pull request as ready for review April 12, 2025 06:15
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. by the way, Are there more PRs about this issue? We plan to release a new version this week. @johngmyers

@johngmyers
Copy link
Contributor Author

I am working through the four functions and will delete the two existing ones, but won't be done this week.

@He1pa He1pa merged commit aef68af into kcl-lang:main Apr 15, 2025
12 checks passed
@johngmyers johngmyers deleted the cidrsubnet branch April 15, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants