feat: lsp complete for unimport schemas. #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles_under_paths to lsp, complete the unimport schemas, and complete the corresponding import schema_pkg Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
He1pa
force-pushed
the
feat_complete_unimport_schemas
branch
from
e5c2c39 to
e4bb7ad
Compare
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
…ze unimported pkg in AdvancedResolver to avoid extra performance loss Signed-off-by: he1pa <18012015693@163.com>
He1pa
force-pushed
the
feat_complete_unimport_schemas
branch
from
04bb4f3 to
b6ca4b2
Compare
He1pa
force-pushed
the
feat_complete_unimport_schemas
branch
from
b6ca4b2 to
3eab378
Compare
He1pa
changed the title
He1pa
force-pushed
the
feat_complete_unimport_schemas
branch
11 times, most recently
from
79e5243 to
1b00f40
Compare
Signed-off-by: he1pa <18012015693@163.com>
He1pa
force-pushed
the
feat_complete_unimport_schemas
branch
from
1b00f40 to
5a967a2
Compare
SkySingh04
pushed a commit
to SkySingh04/kcl
that referenced
this pull request
Dec 24, 2024
* feat: lsp complete for unimport schemas. Apply the new api load_all_files_under_paths to lsp, complete the unimport schemas, and complete the corresponding import schema_pkg Signed-off-by: he1pa <18012015693@163.com> * remove debug code Signed-off-by: he1pa <18012015693@163.com> * Merge duplicate completion items Signed-off-by: he1pa <18012015693@163.com> * only complete in root scope Signed-off-by: he1pa <18012015693@163.com> * move some test data file Signed-off-by: he1pa <18012015693@163.com> * filter schema in resolver, instead of advanced resolver. Do not analyze unimported pkg in AdvancedResolver to avoid extra performance loss Signed-off-by: he1pa <18012015693@163.com> * add ut Signed-off-by: he1pa <18012015693@163.com> * fix windows ut Signed-off-by: he1pa <18012015693@163.com> --------- Signed-off-by: he1pa <18012015693@163.com> Signed-off-by: Akash <akashsingh2210670@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the new api
load_all_files_under_pathsto lsp,complete the unimport(dependent from kcl.mod or under path) schemas. Currently, this completion is only supported in the global scope, not in the local scope.
and complete the corresponding import stmt at the start of file, e.g.,
import helloworldIn konfig
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: