-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for automatic update KCL dependencies on kcl.mod file save #1118
Conversation
I think from a technical architecture perspective, this should be a more universal build system that can be used not only to monitor changes in |
What is the scope of this |
In summary, That is to say, I believe that the PR should not only watch the |
Pull Request Test Coverage Report for Build 8243675034Details
💛 - Coveralls |
hmm, that's a good suggestion tho, we can try to add that in parts like first the flag implementation and then the corresponding implementation of functionalities. Not sure about the real-time running of kcl package(did you meant after every change in the file |
I suggest first providing the tech design of the Watch System, including an explanation of its scalability, how to extend |
Should I start a new discussion in the discussion topics or add a new design in the docs and raise a PR? |
Yes. |
c7431e8
to
e88bb15
Compare
Signed-off-by: Abhishek Kumar <abhishek22512@gmail.com>
Added a new function
watch_kcl_mod
to monitor changes to thekcl.mod
file and trigger dependency updates accordingly.Added a separate
kcl_mod_file_track
function that can be called from the LSP implementation(yet to be explore)I want to know what target folders can be used for the calling of this
kcl_mod_file_track
Related Issue #998
cc @Peefy @zong-zhe @He1pa