Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lexer): fix warnings by 'cargo clippy' for lexer #1000

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

octonawish-akcodes
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #191

2. What is the scope of this PR (e.g. component or file name):

KCLVM/lexer

Before:
image

After:
image

@Peefy
Copy link
Contributor

Peefy commented Jan 24, 2024

@octonawish-akcodes Could you fix the formatting issues in CI using cargo fmt?

Signed-off-by: Abhishek Kumar <abhishek22512@gmail.com>
@octonawish-akcodes
Copy link
Contributor Author

@octonawish-akcodes Could you fix the formatting issues in CI using cargo fmt?

Yes, I was fixing that. Done.

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonawish-akcodes
Copy link
Contributor Author

octonawish-akcodes commented Jan 24, 2024

There was a test failure for the compiler base I was inspecting that but didn't understand.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7638305958

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.4%) to 72.349%

Totals Coverage Status
Change from base Build 7638012343: -15.4%
Covered Lines: 43729
Relevant Lines: 60442

💛 - Coveralls

@Peefy Peefy merged commit 0f99a7c into kcl-lang:main Jan 24, 2024
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants