Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA-Optional: New calendar look #264

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jesperlauridsen
Copy link
Contributor

This is a draft-branch for the new calendar functionality. Not to be merged untill it's ready and approved.

@Pbruun
Copy link
Contributor

Pbruun commented Jan 6, 2025

Awesome! The look and functionality works great. Just find it a bit aggressive with the pop-ups, whenever changing the date in the input. Maybe a timer, if the input remains incorrect, then a pop-up?

picker === 'start' ? (validStartDate.value = false) : (validEndDate.value = false);
errorManager.submitCustomError(
'datepicker-outofRange',
t('error.outofRange'),
Copy link
Contributor

@Pbruun Pbruun Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet to be added to locales. Same for the other CustomErrors regarding the calendar

@@ -1,6 +1,7 @@
<template>
<div class="day-picker container">
<div class="picker-container">
<span class="date-span">Dato:</span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be translated

@jesperlauridsen jesperlauridsen changed the title should do nicely New calendar look Jan 13, 2025
@jesperlauridsen jesperlauridsen changed the title New calendar look DRA-Optional: New calendar look Jan 13, 2025
Copy link
Contributor

@danielqvistcom danielqvistcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE update! :)

A little error:
I get an error, if I delete tekst in inputfield - and then click on a date in the calendar. "Anvend" doesn't turn active.

Design-updates:
Maybe a little less white-space left/right in the inputfield. From left/right-border to tekst.

(All over :hover = #C4F1ED)
Hover on "active date" - should just stay blue.
(dp__active_date:hover)

"Anvend" - in it's "correct result state" needs our "Foward/approve-green" = #49da87

When month/year-menu open:
Bottom icon (call) - change to: X-icon+ "Luk måned"/"Luk år" if possible. Else just "Luk".
Same with hover-color.

Har forsøgt at illustrere det hele her (nederst):

  • Oh sh**, it's in danish. Ehmm...I've pushet design updates and notes, to the bottom of this page:

https://kb-dk.atlassian.net/wiki/spaces/DRAR/pages/13829699/Filtrering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants