Don't recognize NetworkManager if the systemd dns plugin is active #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See some documentation for this here |
|
I have done some work in gof5 WIP branch: kayrus/gof5@ae8f548 |
|
@liorokman I don't have much time to work on tuncfg right now. Feel free to read my WIP code and submit a PR to fix the issue. |
|
Are you developing in the |
Modified the discriminator for NetworkManager to check against the NetworkManager configuration if the mode is systemd-resolved.
|
@liorokman I was too lazy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
NetworkManageris active, but the configured DNS plugin issystemd-resolved, thenIsNetworkManagershould returnfalse. The correct way to configure the system in this case is via thesystemd-resolvedinterface.