Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scalar_mul_divisor #12

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Boog900
Copy link
Contributor

@Boog900 Boog900 commented Oct 1, 2024

No description provided.

@Boog900 Boog900 marked this pull request as ready for review October 1, 2024 00:52
@kayabaNerve kayabaNerve merged commit e7ead9e into kayabaNerve:develop Oct 1, 2024
8 of 9 checks passed
@kayabaNerve
Copy link
Owner

Thank you! This is exactly what was needed here and I really appreciate it. Fixes #12.

Nit that I'd assume ct_gt is implemented using bit operations and ct_eq would be faster (by setting an intermediary variable to Choice::from(0), then doing intermediary |= this_index.ct_eq(&target_index))) due to the structure of our iteration. I wouldn't be surprised if I had my own such minor flaws though.

@kayabaNerve
Copy link
Owner

kayabaNerve commented Oct 1, 2024

*Fixes #11 . This is #12.

@Boog900 Boog900 deleted the improve-decomp branch October 1, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants