Stream's api methods must never throw - handling errors in DecodeStream, EncodeStream #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
This is just a quick fix for #75.
Nodejs stream api is callback based and doesn't handle errors thrown inside api methods.
I've just wrapped in try/catch block implementation of Transform stream in DecodeStream and EncodeStream to handle errors according to stream specs. It's rather mandatory to be able to handle errors when working with streams. In current version of msgpack-lite node process dies due to unhandled error when such error occures: e.g. DecodeStream fed with garbage data or EncodeStream with circular references.
Test cases included.