Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests in Pipeline #294

Merged
merged 32 commits into from
Aug 17, 2024
Merged

E2E Tests in Pipeline #294

merged 32 commits into from
Aug 17, 2024

Conversation

lukebrody
Copy link
Collaborator

@lukebrody lukebrody commented Aug 16, 2024

  • Move lint.yml to check.yml.
  • Create an e2e test Dockerfile, add a build-and-push-image job to send it to Github packages.
  • Create a build-frontend job that builds the site (without data files) and saves it as an artifact.
  • Create a run-e2e-tests job matrix that runs each e2e test file against ci_proxy.ts.
    • ci_proxy.ts prioritizes the built frontend, but falls back to Github density-db for data files.
    • ci_proxy.ts attempts to fall back on the density-db branch with the same name as the urbanstats branch. This allows testing data changes in urbanstats PRs.

@lukebrody lukebrody self-assigned this Aug 16, 2024
@lukebrody
Copy link
Collaborator Author

Example of breakage with a bad code change https://github.com/kavigupta/urbanstats/actions/runs/10416763614/job/28849834856

Copy link
Owner

@kavigupta kavigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Make sure to squash merge rather than merging

@kavigupta kavigupta merged commit e2e2daa into master Aug 17, 2024
24 checks passed
@kavigupta kavigupta deleted the lb/docker-test branch August 17, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants