dev-new_vorbin_flux #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…length resolution, projected distance and line-of-sight velocity of that particle.
…he flux - this is now done in compute_flux.
…t of these spaxel functions - need these maps to be at intrinsic instrument resolution, not binned.
…defined as a function.
…es come from the pixelated maps, not vorbinned ones.
… including the summed mass image as default (as in velocity method).
…t list in raw_images (in case anyone is querying these by index).
… weighted or flux weighted.
…mage outputs for spectral files.
…ucing the same images but with now updated BUNIT in header file if mass flag TRUE, Msol.
…the length of the output images.
… to a specific commit of the remote GitHub package.
…s. Also making sure added raw mass images output are unlinked at the end of the tests.
dev-mass_flag
…o prior to plotting.
… now pulling from remote location as in "remotes")
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 89.94% 90.89% +0.94%
==========================================
Files 17 17
Lines 3472 3427 -45
==========================================
- Hits 3123 3115 -8
+ Misses 349 312 -37 ☔ View full report in Codecov by Sentry. |
Modifications for pak syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardising which cubes/images output are voronoi binned.
Properties, such as the mass, flux and number of particles, are produced simply as the sum along that line-of-sight and as such should be presented at the pixel resolution of the instrument. As default, summed images are now given in this way, while any spectral/velocity cubes are binned along with any output average maps (kinematics such as velocity, dispersion, h3 and h4, metallicity and age).
The same is done for gas maps, with all but the mass, SFR and particle number being given in binned form when the voronoi function is turned on.
Also, added
raw_images$mass_imageto the output of spectral mode as this is now "free"" to produce. Added to the end of the output list of raw images so as to not cause any numerical indexing issues to arise in older code.