dev-TNG_fix #101
Merged
dev-TNG_fix #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has a method to test for the input file type.
Merge branch 'dev-tispy_binary_file_support' of github.com:kateharborne/SimSpin into dev-tispy_binary_file_support # Conflicts: # R/utilities.R
…t use this later on in cube construction.
…download script do not include this!)
…tasets for SimSpin. Added for EAGLE, TNG, Magneticum and HorizonAGN.
…lly listed (not a new invented one).
…ad routines now removed from the Utilities function file, "utilities.R".
…download script do not include this!)
…t use this later on in cube construction.
…tasets for SimSpin. Added for EAGLE, TNG, Magneticum and HorizonAGN.
…lly listed (not a new invented one).
Merge branch 'dev-TNG_fix' of github.com:kateharborne/SimSpin into dev-TNG_fix # Conflicts: # DESCRIPTION # NEWS.md # README.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 90.90% 91.03% +0.13%
==========================================
Files 17 18 +1
Lines 3430 3492 +62
==========================================
+ Hits 3118 3179 +61
- Misses 312 313 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix. Updating the read in functions for cosmological models input to prevent the code falling over when attributes are not provided for Datasets that are unnecesary for SimSpin to function.
Read file functions have been shifeted to a new .R file for ease of reading the source code. This is now contained in
read_files.R, rather thanutilities.R.This fix means that HDF5 files extracted directly from the TNG database for galaxy cutouts will now produce outputs successfully, fixing Issue #95.