Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect calculation of the kappa parameter in sim_analysis #114

Open
1 task done
kateharborne opened this issue Oct 28, 2024 · 0 comments
Open
1 task done

Incorrect calculation of the kappa parameter in sim_analysis #114

kateharborne opened this issue Oct 28, 2024 · 0 comments
Assignees
@kateharborne
Labels
bug

Comments

@kateharborne
Copy link
Owner

kateharborne commented Oct 28, 2024 •
edited
Loading

Credit to Ryan Bagge for catching that the radial velocity measure in the denominator is the spherically averaged one rather than the cylindrical measure.

  • Modify cylindrical quantities to ensure the correct value is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kateharborne kateharborne

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kateharborne