Add check versions of functions #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordicaleksa
force-pushed
the
add_close_check_socket
branch
from
90aed62
to
5f5427f
Compare
gordicaleksa
force-pushed
the
add_close_check_socket
branch
from
d1c5b53
to
27fe5ef
Compare
gordicaleksa
force-pushed
the
add_close_check_socket
branch
from
5c2015c
to
6b62f3b
Compare
rosslwheeler
reviewed
Jul 2, 2024
| @@ -15,6 +15,10 @@ | |||
| // implementation of dirent for Windows is in dev/unistd.h | |||
| #ifndef _WIN32 | |||
| #include <dirent.h> | |||
| #include <arpa/inet.h> | |||
| #else | |||
There was a problem hiding this comment.
You may be able to move the winsock2.h file into dev/unistd.h. I would try to remove the pragma (if possible) and use an explicit /link Ws2_32.lib in LDLIBS in the Windows section of the Makefile (but have not tested this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add socket close check functions - consistent with the rest of the codebase.