-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make msvc compile and improve CI #216
Conversation
😅 Huggingface is straining.
I promise it works! And removes the warnings for
|
Also resolves #217 ... partially |
the shakespeare download is super tiny, is it causing issues in the CI? should we be paying the cost of merging that to the repo for it? |
Chances are it was the GPT2 download, maybe I didn't stare at the log hard enough... but: |
Of course you're right. This is why #215 failed: |
Still, so far it's one less download costing just 1M ... and it fixes Should I move all the output |
@@ -1,8 +1,10 @@ | |||
# dot files and such | |||
.vscode/ | |||
.venv/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
/.vs
as well please for visual studio
I don't want to clutter the repo with shakespeare if we can avoid it. It's a pet peeve to git clone a repo and have to wait long seconds/minutes for the download. |
Let's not move the bin files right now, let's try to keep this PR focused and minimal |
Impressive that this repo is still under 2M, including all history. New PR incoming. |
Fixes #200 breaking
msvc
.