web_terminal_front #207

MdSayemkhan · 2025-03-28T19:48:31Z

What type of PR is this?

What this PR does / why we need it:
/kind feature

Which issue(s) this PR fixes:
Fixes #57

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
yes

karmada-bot · 2025-03-28T19:48:41Z

Welcome @MdSayemkhan! It looks like this is your first PR to karmada-io/dashboard 🎉

warjiang · 2025-03-29T02:39:36Z

/assign

karmada-bot · 2025-04-13T20:53:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from warjiang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

MdSayemkhan · 2025-04-13T21:15:35Z

/assign @warjiang

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

warjiang · 2025-04-18T03:20:48Z

artifacts/dashboard/kubeconfig.yaml

kubeconfig file should not be submitted

warjiang · 2025-04-18T03:24:12Z

artifacts/dashboard/ttyd-pod.yaml

+  namespace: karmada-system
+spec:
+  containers:
+  - image: docker.io/sayem4604/ttyd:latest


Can you provide with the original Dockerfile for building docker.io/sayem4604/ttyd:latest image, it will help our customer to clarify what we add in the image, also we can make some customization to to ttyd image, make it more convenient for karmada community.

warjiang · 2025-04-18T03:27:39Z

artifacts/dashboard/ttyd-pod.yaml

I think we will not use the pod file directly, we can integrate the pod file with golang, like followoing:

pod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: "ttyd-cbf14e3f-f53a-4e0c-99e2-b39ebc0d221d", Namespace: "karmada-system", }, Spec: v1.PodSpec{ Containers: []v1.Container{ { Name: "ttyd-cbf14e3f-f53a-4e0c-99e2-b39ebc0d221d", Image: "docker.io/sayem4604/ttyd:latest", Ports: []v1.ContainerPort{ { ContainerPort: 7681, }, }, }, }, }, } podsClient := clientset.CoreV1().Pods("karmada-system") result, err := podsClient.Create(context.TODO(), pod, metav1.CreateOptions{}) if err != nil { panic(err.Error()) }

!!! Above is just an example, don't use it directly in your programe.

warjiang · 2025-04-18T03:28:46Z

cmd/api/app/api.go

+// Call the web_terminal function from the main entry point
+func main() {
+	web_terminal() // Ensure this is called to initialize the terminal setup
+}


add extra line at the end of the file

warjiang · 2025-04-18T03:29:45Z

cmd/api/app/api.go

+	terminal_setup.Init()// Call the init function if it exists
+}
+
+// Call the web_terminal function from the main entry point


the main file is useless, i seems that it just for testing, testing code expect UT code should not be submitted.

warjiang · 2025-04-18T03:36:33Z

ui/apps/dashboard/src/layout/index.tsx

@@ -52,6 +55,16 @@ export const MainLayout: FC = () => {
          <Outlet />
        </AntdContent>
      </AntdLayout>
+      <Navigation onTerminalClick={() => setIsTerminalOpen(true)} />


here you will add two navigation component ?

warjiang · 2025-04-18T03:37:25Z

ui/apps/dashboard/vite.config.ts

@@ -52,7 +52,9 @@ export default defineConfig(({ mode }) => {
      }),
    ],
    resolve: {
-      alias: [{ find: '@', replacement: path.resolve(__dirname, 'src') }],
+      alias: [{ find: '@', replacement: path.resolve(__dirname, 'src') },


format the code

warjiang · 2025-04-18T03:38:54Z

ui/packages/xterm-addon-zmodem/tsconfig.json

@@ -8,10 +8,9 @@

    /* Bundler mode */
    "moduleResolution": "bundler",
-    "allowImportingTsExtensions": true,
+    /*"allowImportingTsExtensions": true,*/


any explanation for the change

warjiang · 2025-04-18T03:39:58Z

ui/packages/terminal/src/ttyd.ts

@@ -18,6 +18,7 @@ import type { ITerminalOptions } from '@xterm/xterm';
 import { addEventListener, getDebugger } from './utils';
 import BaseTerminal from './base.ts';
 import { BaseTerminalOptions, ClientOptions } from './typing';
+//import ZmodemAddon from '@karmada/xterm-addon-zmodem';


plz recheckt the code, when submit PR, I think you can clean your code

warjiang · 2025-04-18T03:42:14Z

ui/packages/terminal/src/terminal_setup/handler.go

kind of the golang code should be move to api module under the cmd folder

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 28, 2025

karmada-bot requested review from jhnine and samzong March 28, 2025 19:48

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 28, 2025

MdSayemkhan changed the title ~~web_termiminal~~ web_terminal_front Mar 28, 2025

MdSayemkhan force-pushed the feature-add_web_terminal branch from f54a650 to cb63771 Compare March 28, 2025 19:59

karmada-bot assigned warjiang Mar 29, 2025

MdSayemkhan added 3 commits April 14, 2025 03:01

web_termiminal

553b15d

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

Updated license section in [TerminalPopup.tsx]

0a70e05

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

web_socket connection with ttyd-pod

fa3403c

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

MdSayemkhan force-pushed the feature-add_web_terminal branch from 9e137dd to fa3403c Compare April 13, 2025 21:02

MdSayemkhan added 2 commits April 14, 2025 14:51

fix: build error due to missing types for sockjs-client

9aa3901

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

fix: CI with sign-off

27f89f2

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2025

warjiang reviewed Apr 18, 2025

View reviewed changes

MdSayemkhan added 2 commits April 23, 2025 17:22

backend using direct golang

77ae70b

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

sockjs issue

fe15550

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 12, 2025

sockjs connection problem

f960315

Signed-off-by: MdSayemkhan <sayemkhan4604@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

web_terminal_front #207

web_terminal_front #207

MdSayemkhan commented Mar 28, 2025

karmada-bot commented Mar 28, 2025

warjiang commented Mar 29, 2025

karmada-bot commented Apr 13, 2025

MdSayemkhan commented Apr 13, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

warjiang Apr 18, 2025

web_terminal_front #207

Are you sure you want to change the base?

web_terminal_front #207

Conversation

MdSayemkhan commented Mar 28, 2025

karmada-bot commented Mar 28, 2025

warjiang commented Mar 29, 2025

karmada-bot commented Apr 13, 2025

MdSayemkhan commented Apr 13, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment