Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize NIRCam spectra support, updates for STIS, etc. #119

Merged
merged 6 commits into from
May 23, 2024

Conversation

karllark
Copy link
Owner

@karllark karllark commented Feb 20, 2024

Finalize NIRCam slitless capabilities. Both observed and mocked spectra.

Adding keyword to only read in certain bands (useful for SED modeling).

Adding in new STIS filenaming convention.

Other minor improvements.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 105 lines in your changes missing coverage. Please review.

Project coverage is 40.10%. Comparing base (819b545) to head (553e852).
Report is 7 commits behind head on master.

Files Patch % Lines
measure_extinction/utils/merge_nircam_spec.py 15.62% 54 Missing ⚠️
measure_extinction/utils/merge_miri_ifu_spec.py 8.57% 32 Missing ⚠️
measure_extinction/stardata.py 58.33% 10 Missing ⚠️
measure_extinction/utils/plot_mspec.py 14.28% 6 Missing ⚠️
measure_extinction/utils/merge_stis_spec.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   41.04%   40.10%   -0.94%     
==========================================
  Files          21       22       +1     
  Lines        2863     2977     +114     
==========================================
+ Hits         1175     1194      +19     
- Misses       1688     1783      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark karllark changed the title updating for new STIS filenames and minor improvements Add NIRCam and MIRI Spectra May 7, 2024
@karllark karllark changed the title Add NIRCam and MIRI Spectra Add NIRCam and MIRI spectra support May 7, 2024
@karllark karllark changed the title Add NIRCam and MIRI spectra support Finalize NIRCam spectra support, updates for STIS, etc. May 13, 2024
@karllark karllark merged commit 706d4e6 into master May 23, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant