remarks

karafka · Sep 22, 2023 · 9f6ba5c · 9f6ba5c
1 parent e97209d
commit 9f6ba5c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -35,9 +35,6 @@ jobs:
           ruby-version: ${{matrix.ruby}}
           bundler-cache: true
 
-      - name: Remove libzstd-dev to check no supported compressions
-        run: sudo apt-get -y remove libzstd-dev
-
       - name: Run Kafka with docker-compose
         run: |
           docker-compose up -d

diff --git a/spec/lib/waterdrop/producer/sync_spec.rb b/spec/lib/waterdrop/producer/sync_spec.rb
@@ -112,10 +112,10 @@
       it { expect(delivery).to be_a(Rdkafka::Producer::DeliveryReport) }
     end
 
-    context 'when it is not installed zstd' do
+    context 'when it is installed zstd' do
       let(:codec) { 'zstd' }
 
-      it { expect { delivery }.to raise_error(Rdkafka::Config::ConfigError) }
+      it { expect(delivery).to be_a(Rdkafka::Producer::DeliveryReport) }
     end
 
     context 'when it is installed lz4' do