[1.x] Fix Vite Hot File Detection #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # InertiaCore/Extensions/Configure.cs # InertiaCore/Utils/Vite.cs # InertiaCoreTests/UnitTestVite.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building out #34, I noticed my Vite HMR wasn't working. While this could be fixed in the vite.config.js, I think the software should work correctly with the updated examples in #31.
This splits out fetching the public path and the build path into two separate functions. Only hot file detection utilizes the new public path, while the rest of the references are updated to fetch the build path. Effectively, this only changes the hot file path detection.
To be merged after #34.