Remove grpc-es closer (#28)

kanziw · Aug 13, 2024 · d51f301 · d51f301
1 parent c58bb3a
commit d51f301
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 62 deletions.
diff --git a/.yarn/cache/@bufbuild-protobuf-npm-2.0.0-c1ded0094a-a46ed4d329.zip b/.yarn/cache/@bufbuild-protobuf-npm-2.0.0-c1ded0094a-a46ed4d329.zip
diff --git a/.yarn/cache/@bufbuild-protoc-gen-es-npm-1.10.0-b0efbb5fe3-e8add92c05.zip b/.yarn/cache/@bufbuild-protoc-gen-es-npm-1.10.0-b0efbb5fe3-e8add92c05.zip
diff --git a/.yarn/cache/@bufbuild-protoc-gen-es-npm-2.0.0-c382f64b11-9f55d08f38.zip b/.yarn/cache/@bufbuild-protoc-gen-es-npm-2.0.0-c382f64b11-9f55d08f38.zip
diff --git a/.yarn/cache/@bufbuild-protoplugin-npm-2.0.0-0686b2acd6-62785bab52.zip b/.yarn/cache/@bufbuild-protoplugin-npm-2.0.0-0686b2acd6-62785bab52.zip
diff --git a/.yarn/cache/@typescript-vfs-npm-1.6.0-db712237c3-58b79ceb5d.zip b/.yarn/cache/@typescript-vfs-npm-1.6.0-db712237c3-58b79ceb5d.zip
diff --git a/packages/grpc-es/package.json b/packages/grpc-es/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@kanziw/grpc-es",
   "type": "module",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "A collection of grpc libraries using connect-es",
   "repository": {
     "type": "git",
@@ -35,14 +35,9 @@
     "@connectrpc/connect": "^1.4.0",
     "@connectrpc/connect-node": "^1.4.0"
   },
-  "peerDependencies": {
-    "@bufbuild/protobuf": "^1.10.0",
-    "@connectrpc/connect": "^1.4.0",
-    "@connectrpc/connect-node": "^1.4.0"
-  },
   "devDependencies": {
     "@bufbuild/buf": "^1.36.0",
-    "@bufbuild/protoc-gen-es": "^2.0.0",
+    "@bufbuild/protoc-gen-es": "^1.10.0",
     "@connectrpc/protoc-gen-connect-es": "^1.4.0",
     "nanobundle": "^2.0.0",
     "publish-if-not-published": "^3.1.3",

diff --git a/packages/grpc-es/src/server/server.ts b/packages/grpc-es/src/server/server.ts
@@ -9,7 +9,6 @@ import type { Interceptor } from './types.js'
 export class GrpcEsServer {
   private interceptors: Interceptor[] = []
   private services: { service: ServiceType; implementation: ServiceImpl<ServiceType> }[] = []
-  private http2Server: http2.Http2Server | null = null
 
   constructor(private options?: Partial<UniversalHandlerOptions>) {}
 
@@ -38,7 +37,7 @@ export class GrpcEsServer {
   }
 
   listenAndServe(port: number): void {
-    this.http2Server = http2
+    http2
       .createServer(
         connectNodeAdapter({
           routes: (router) => {
@@ -50,17 +49,6 @@ export class GrpcEsServer {
       )
       .listen(port)
   }
-
-  async close(): Promise<void> {
-    const server = this.http2Server
-    if (!server) {
-      return
-    }
-
-    return new Promise((resolve, reject) => {
-      server.close((err) => (err ? reject(err) : resolve()))
-    })
-  }
 }
 
 function makeUnimplementedService<Service extends ServiceType>(service: Service): ServiceImpl<Service> {

diff --git a/yarn.lock b/yarn.lock
@@ -1878,42 +1878,24 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@bufbuild/protobuf@npm:2.0.0, @bufbuild/protobuf@npm:^2.0.0":
-  version: 2.0.0
-  resolution: "@bufbuild/protobuf@npm:2.0.0"
-  checksum: a46ed4d329ce14e162b0ffe0b7f7db7c21ea5174757b5c1ce7bd8a84509603932d5ba51efeaa895fb2ecbf4e10e8c10f4fbf65f880f9a5abe00929ebd850e18e
-  languageName: node
-  linkType: hard
-
-"@bufbuild/protoc-gen-es@npm:^2.0.0":
-  version: 2.0.0
-  resolution: "@bufbuild/protoc-gen-es@npm:2.0.0"
+"@bufbuild/protoc-gen-es@npm:^1.10.0":
+  version: 1.10.0
+  resolution: "@bufbuild/protoc-gen-es@npm:1.10.0"
   dependencies:
-    "@bufbuild/protobuf": "npm:^2.0.0"
-    "@bufbuild/protoplugin": "npm:2.0.0"
+    "@bufbuild/protobuf": "npm:^1.10.0"
+    "@bufbuild/protoplugin": "npm:1.10.0"
   peerDependencies:
-    "@bufbuild/protobuf": 2.0.0
+    "@bufbuild/protobuf": 1.10.0
   peerDependenciesMeta:
     "@bufbuild/protobuf":
       optional: true
   bin:
     protoc-gen-es: bin/protoc-gen-es
-  checksum: 9f55d08f380ab7cbfdac7f451af9f472d461639f67a4db9fb7b239955ee9e485219da22886db86dc83279e0b2942b330201946166868c7d4bb010785b4021607
+  checksum: e8add92c05ce341e2693ce9e0ffbfc6c1287bf08cbdcb828480b990f5240599b0f6f679ac5ea102e46d5dfbf14318a5ddf30b250a887893f8da3a959776cec14
   languageName: node
   linkType: hard
 
-"@bufbuild/protoplugin@npm:2.0.0":
-  version: 2.0.0
-  resolution: "@bufbuild/protoplugin@npm:2.0.0"
-  dependencies:
-    "@bufbuild/protobuf": "npm:2.0.0"
-    "@typescript/vfs": "npm:^1.5.2"
-    typescript: "npm:5.4.5"
-  checksum: 62785bab52c74bfb8aeb55696ad0c5762142ff276631c14ee5abae1cbb65376a95ec70129ded485f9348997a03efecd26fc81665ddd2a0a8adb7c54baf568a19
-  languageName: node
-  linkType: hard
-
-"@bufbuild/protoplugin@npm:^1.7.2":
+"@bufbuild/protoplugin@npm:1.10.0, @bufbuild/protoplugin@npm:^1.7.2":
   version: 1.10.0
   resolution: "@bufbuild/protoplugin@npm:1.10.0"
   dependencies:
@@ -2953,7 +2935,7 @@ __metadata:
   dependencies:
     "@bufbuild/buf": "npm:^1.36.0"
     "@bufbuild/protobuf": "npm:^1.10.0"
-    "@bufbuild/protoc-gen-es": "npm:^2.0.0"
+    "@bufbuild/protoc-gen-es": "npm:^1.10.0"
     "@connectrpc/connect": "npm:^1.4.0"
     "@connectrpc/connect-node": "npm:^1.4.0"
     "@connectrpc/protoc-gen-connect-es": "npm:^1.4.0"
@@ -2962,10 +2944,6 @@ __metadata:
     rimraf: "npm:^5.0.5"
     tsx: "npm:^4.6.2"
     typescript: "npm:^5.3.3"
-  peerDependencies:
-    "@bufbuild/protobuf": ^1.10.0
-    "@connectrpc/connect": ^1.4.0
-    "@connectrpc/connect-node": ^1.4.0
   languageName: unknown
   linkType: soft
 
@@ -3270,17 +3248,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@typescript/vfs@npm:^1.5.2":
-  version: 1.6.0
-  resolution: "@typescript/vfs@npm:1.6.0"
-  dependencies:
-    debug: "npm:^4.1.1"
-  peerDependencies:
-    typescript: "*"
-  checksum: 58b79ceb5db9e8dc374d6e7348866c62f2a80664bccda7064e823a0a7a7b05c71cff06e5d27ca2ef56b3cec84c3631cec9cd6fed49ea0ccc6ace812f8c318b37
-  languageName: node
-  linkType: hard
-
 "abbrev@npm:1":
   version: 1.1.1
   resolution: "abbrev@npm:1.1.1"