fix(SUP-46270): [MultiCustomer] Captions Not Showing After Enabling Them #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzipi-kaltura
requested review from
SivanA-Kaltura,
MosheMaorKaltura and
semarche-kaltura
MosheMaorKaltura
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
When playing video with cc disabled, captions are not displayed after enable the caption. this happens when we have default caption and we generate webVTT captions.
This was fixed here - #219 but seems it was only partial fix and was tested only when "Auto generate WebVTT captions" is enabled.
the fix here - #221 should complete the fix but was tested only on original webVTT (and also not default caption) and not in generate webVTT.
This fix is tested and working for all cases - srt, webVTT and generate webVTT not and default captions
Fix:
Only if there is a default caption we will listen to SUBTITLE_FRAG_PROCESSED otherwise we can hide the caption immediately
Resolves SUP-46270