fix(SUP-44638): [Vanguard] Media Stream Error in EP #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbalvasserman
requested review from
MosheMaorKaltura,
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
| @@ -9,7 +9,7 @@ | |||
| }, | |||
| "BigBugBunnuy": { | |||
| "mimetype": "application/x-mpegurl", | |||
| "url": "https://qa-apache-php7.dev.kaltura.com/p/1091/sp/109100/playManifest/entryId/0_wifqaipd/protocol/https/format/applehttp/flavorIds/0_h65mfj7f,0_3flmvnwc,0_m131krws,0_5407xm9j,0_xcrwyk2n/a.m3u8" | |||
| "url": "https://cdnapisec.kaltura.com/p/243342/sp/24334200/playManifest/entryId/1_hqzw282w/flavorIds/1_xnk563b4,1_ie3m16r9,1_zxeh6miu/format/applehttp/protocol/https/a.m3u8" | |||
SivanA-Kaltura
requested changes
Nov 26, 2024
SivanA-Kaltura
approved these changes
Nov 27, 2024
MosheMaorKaltura
approved these changes
Nov 27, 2024
Tzipi-kaltura
added a commit
that referenced
this pull request
Dec 30, 2024
…hem (#222) Issue: When playing video with cc disabled, captions are not displayed after enable the caption. this happens when we have default caption and we generate webVTT captions. This was fixed here - #219 but seems it was only partial fix and was tested only when "Auto generate WebVTT captions" is enabled. the fix here - #221 should complete the fix but was tested only on original webVTT (and also not default caption) and not in generate webVTT. This fix is tested and working for all cases - srt, webVTT and generate webVTT not and default captions Fix: Only if there is a default caption we will listen to SUBTITLE_FRAG_PROCESSED otherwise we can hide the caption immediately Resolves SUP-46270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
when use vtt captions there is internal error on console
this is cause in the function _onSubtitleFragProcessed where this._hls is null and so this._hls.subtitleTrack cannot be perform and throw the error
fix:
change context in off/on functions to be this and not this._hls
while captions are disabled add check for number of captions because when using 1 captions the event is not calling until enable the captions and then the captions are not seeing on screen
Resolves SUP-44638