pkp#10362 check if data exists before running migrations

kaitlinnewson · Dec 19, 2024 · dee1d47 · dee1d47
1 parent 3a750ac
commit dee1d47
Showing 1 changed file with 16 additions and 11 deletions.
diff --git a/classes/migration/upgrade/v3_5_0/I10362_EventLogEditorNames.php b/classes/migration/upgrade/v3_5_0/I10362_EventLogEditorNames.php
@@ -43,21 +43,26 @@ public function up(): void
             ->pluck('user_id', 'log_id');
 
         $inserts = [];
-        foreach ($idsToUpdate as $eventLogId => $userId) {
-            $editorName = Repo::user()->get($userId)->getFullName();
 
-            if ($editorName) {
-                $inserts[] = [
-                    'log_id' => $eventLogId,
-                    'locale' => '',
-                    'setting_name' => 'editorName',
-                    'setting_value' => $editorName
-                ];
+        if ($idsToUpdate) {
+            foreach ($idsToUpdate as $eventLogId => $userId) {
+                $editorName = Repo::user()->get($userId)->getFullName();
+
+                if ($editorName) {
+                    $inserts[] = [
+                        'log_id' => $eventLogId,
+                        'locale' => '',
+                        'setting_name' => 'editorName',
+                        'setting_value' => $editorName
+                    ];
+                }
             }
         }
 
-        DB::table('event_log_settings')
-            ->insert($inserts);
+        if ($inserts) {
+            DB::table('event_log_settings')
+                ->insert($inserts);
+        }
     }
 
     /**