-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utf16 to utf8, Add usage example #16
base: master
Are you sure you want to change the base?
Conversation
utf16_to_utf8 used in stringdecode.decode
*document
usage +close() kaitaistruct\ .class .string_stream ..
I guess it should use the package, not inline the source. |
Could wrap inline source to single function, although the code is a little long. |
I meant a LuaRocks package. |
Oh, sorry, not familiar with generating LuaRocks. |
I mean your patch mentions the code had been taken from https://github.com/robertlzj/lua_utf16_to_utf8 . Maybe we shouldn't inline the code, but make https://github.com/robertlzj/lua_utf16_to_utf8 a LuaRocks package and just import it? |
Haha, lua_utf16_to_utf8 is my fork from another source, only adjust to match kaitai lua. |
Honestly, don't hold your breath until this pull request is merged. I can already see that there are several issues that will have to be solved, I'll have to make a significant effort to get this ready and it's not the top priority for me at the moment, sorry. |
Haha, OK, I'm fine. Glad to push any progress. |
utf16_to_utf8 used in stringdecode.decode