Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utf16 to utf8, Add usage example #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robertlzj
Copy link

utf16_to_utf8 used in stringdecode.decode

robertlzj added 2 commits May 21, 2022 21:10
utf16_to_utf8 used in stringdecode.decode
usage +close()
kaitaistruct\ .class .string_stream ..
@KOLANICH
Copy link

I guess it should use the package, not inline the source.

@robertlzj
Copy link
Author

robertlzj commented May 22, 2022

Could wrap inline source to single function, although the code is a little long.
But since it's not reuse anywhere, and as private function, could just keep in line source for easier file organize.
Both OK.

@KOLANICH
Copy link

I meant a LuaRocks package.

@robertlzj
Copy link
Author

Oh, sorry, not familiar with generating LuaRocks.
And you mean package of patch?

@KOLANICH
Copy link

I mean your patch mentions the code had been taken from https://github.com/robertlzj/lua_utf16_to_utf8 . Maybe we shouldn't inline the code, but make https://github.com/robertlzj/lua_utf16_to_utf8 a LuaRocks package and just import it?

@robertlzj
Copy link
Author

Haha, lua_utf16_to_utf8 is my fork from another source, only adjust to match kaitai lua.
I would like to avoid to package it, for I'm not the designer, and can't do further update.
Whatever that is convenient for you~

@generalmimon
Copy link
Member

Honestly, don't hold your breath until this pull request is merged. I can already see that there are several issues that will have to be solved, I'll have to make a significant effort to get this ready and it's not the top priority for me at the moment, sorry.

@robertlzj
Copy link
Author

Haha, OK, I'm fine. Glad to push any progress.
Great project, honestly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants