Add support for parameters in types #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I ask you to rebase it against latest master and we'll merge it right away? |
|
Rebased and CI is also fixed |
GreyCat
reviewed
Jan 26, 2020
| "public class (.+?) extends KaitaiStruct.*" + | ||
| "public \\1\\(KaitaiStream _io, KaitaiStruct _parent, \\1 _root(.*?)\\)", | ||
| Pattern.DOTALL | ||
| ); |
There was a problem hiding this comment.
Actually, nowadays top class name should not be that hard to get. Probably we should expose JavaMain.compileOneInput that will clearly return compilation result as Java object, and that object contains reference to top class name.
|
Thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even
ksvhas no such feature (see kaitai-io/kaitai_struct_visualizer#33). Now you can look at parameterized types somehow:Based on #6, so can be merged instead of #6.