Fix controllers that do not check log-in status before running #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `before_action :require_logged_in` call to the controllers that expects that user is logged in. refs: kaigionrails#122
tk0miya
commented
Nov 12, 2023
| @@ -1,4 +1,6 @@ | |||
| class SampleWebpushNotificationsController < ApplicationController | |||
| before_action :require_logged_in | |||
There was a problem hiding this comment.
I'm not sure if it's not good or not that blocking the #create request by redirecting. But it would be better than a crash to me.
unasuke
requested changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
before_action :require_logged_incall to the controllers that expects that user is logged in.refs: #122