Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the supported Rife versions #1303

Closed
Groudonx opened this issue Jan 20, 2025 · 10 comments · Fixed by #1304
Closed

Update the supported Rife versions #1303

Groudonx opened this issue Jan 20, 2025 · 10 comments · Fixed by #1304
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request

Comments

@Groudonx
Copy link

I've heard that Rife optimizes for anime scenes in the version 4.7.

The latest frame interpolation rife version supported by video2x seems to be 4.6 (this shows up for me in the list on Windows).

I think it would be nice to include these newer versions of Rife for a better output quality.

@Groudonx Groudonx added the type:Enhancement New feature or request label Jan 20, 2025
@github-actions github-actions bot added the state:Backlog This issue will be worked on in the future label Jan 20, 2025
@k4yt3x
Copy link
Owner

k4yt3x commented Jan 20, 2025

Thanks for the heads up, I didn't know they released a new version. I'll check it out.

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 20, 2025

I'm actually not sure where the new models are released. The ones that are currently included are from https://github.com/nihui/rife-ncnn-vulkan. Could you please give me a link to where you saw the 4.7 model?

@Pete4K
Copy link

Pete4K commented Jan 20, 2025

Maybe he means this: https://github.com/hzwer/ECCV2022-RIFE
There is Something with Rife 4.7-4.10

@Groudonx
Copy link
Author

I only heard about if, unfortunately I'm not very well versed on the technical side of things.

The Rife Vulkan Github you linked has the open issue nihui/rife-ncnn-vulkan#66 so I'd assume it's not included there yet. The issue was opened more than a year ago, which lead me to believe that this Rife version may be accessible by now.

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 20, 2025

@Pete4K Yup thanks. I saw that repo but I didn't find the download links. It turned to be in https://github.com/hzwer/Practical-RIFE/tree/main#model-list. The models appear be in flownet pytorch format. We'll need to convert them to ncnn somehow.

@B1ACK917
Copy link
Contributor

@Pete4K Yup thanks. I saw that repo but I didn't find the download links. It turned to be in https://github.com/hzwer/Practical-RIFE/tree/main#model-list. The models appear be in flownet pytorch format. We'll need to convert them to ncnn somehow.

Hi k4ty3k, I'm trying to convert 4.26 RIFE model to ncnn format, got a bin file and a param file. However, I installed the video2x using deb file, where should I put the model file so that I can test the converted model?

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 21, 2025

@B1ACK917 it should go under something like /usr/share/video2x/models/rife/rife-4.26. However the CLI argument parser won't recognize the new model, you can try replacing the files of an existing model

@Pete4K
Copy link

Pete4K commented Jan 21, 2025

Btw, does Somebody know how I can train models? I would like to train the Real ESRGAN Anime Plus model vor Videos and maybe more frames/sec. I don't know If I have to do Something with Programming Languages, because I'm bad with it.

@B1ACK917
Copy link
Contributor

@k4yt3x After some attempts, I found the 4.2x model is quite different from v4.6, so I need to fit some code and recompile the project to test, lol. Now I have added the support for 4.25, 4.25-lite and 4.26, but I need to change the librife code, because version > 4.6 changed the padding and add a memorydata layer, so I will first open a PR in that librife repo, I'm on it, please check it later.

@k4yt3x k4yt3x linked a pull request Jan 21, 2025 that will close this issue
@k4yt3x k4yt3x added state:InProgress This issue is being worked on state:Testing The related code is being tested for release and removed state:Backlog This issue will be worked on in the future state:InProgress This issue is being worked on labels Jan 21, 2025
@github-actions github-actions bot added state:Done This issue has been resolved/dismissed and removed state:Testing The related code is being tested for release labels Jan 21, 2025
@k4yt3x
Copy link
Owner

k4yt3x commented Jan 21, 2025

Thanks for the PR. I've tested and merged it. It seems to work well:

Image

I'll proceed to adding this model to the GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants