Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add more files to the Processing Queue #1281

Closed
Pete4K opened this issue Jan 3, 2025 · 10 comments
Closed

Possibility to add more files to the Processing Queue #1281

Pete4K opened this issue Jan 3, 2025 · 10 comments
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request

Comments

@Pete4K
Copy link

Pete4K commented Jan 3, 2025

It would be great to add more files to the Processing Queue without aborting a file in the whole Queue. Furthermore it would be great to choose an Option that finished files disappear from the Queue.

@github-actions github-actions bot added the state:Backlog This issue will be worked on in the future label Jan 3, 2025
@k4yt3x k4yt3x added type:Enhancement New feature or request component:GUI labels Jan 3, 2025
@k4yt3x
Copy link
Owner

k4yt3x commented Jan 4, 2025

add more files to the Processing Queue without aborting a file in the whole Queue

Yeah that'll be a nice-to-have. It'll just require more careful management of the objects.

it would be great to choose an Option that finished files disappear from the Queue

I agree. It can be added relatively easily as a checkbox or combo box.

@k4yt3x k4yt3x added state:Planned This issue is already scheduled to be worked on and removed state:Backlog This issue will be worked on in the future labels Jan 4, 2025
@GautDlpr
Copy link

GautDlpr commented Jan 6, 2025

You can already do this by dragging and dropping the new files to be processed during the current process, and it works very well.

@Pete4K
Copy link
Author

Pete4K commented Jan 6, 2025

I have to try this again.

@Pete4K
Copy link
Author

Pete4K commented Jan 6, 2025

OK, that seems to Work now. But the Checkbox is still a good idea

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 7, 2025

@GautDlpr tbh that wasn't intended haha

I didn't intend to allow adding more files on the fly because I'm afraid the index math will go wrong. I haven't really tested that functionality. I guess adding won't be too big of a deal, it's when autoremove is added will it require changes.

@GautDlpr
Copy link

GautDlpr commented Jan 7, 2025

@k4yt3x if you're talking about the index of pending files, it's not wrong (at least in the interface). If you're talking about another index, idk.

One thing's for sure, though: if it's affected the quality of my processed files, I'm going to cry, because over the last few days I've been processing an insane number of videos, many of which have been added on the fly.

I haven't done any quality check yet, but I'll let you know if I need to buy a big box of tissues 🥲.

@Pete4K
Copy link
Author

Pete4K commented Jan 7, 2025

But I think it should be useful, when you are able to use the "REMOVE", "ADD" and "CLEAR" function for every processing file in the GUI, so that you can clear every file you want one after one. For that these functions shouldn't be in a grey out-status. Then adding the checkbox in the options, when you want every successful file to be removed.

@Pete4K
Copy link
Author

Pete4K commented Jan 7, 2025

@GautDlpr Yes, it should not affect the quality or the processing time, that's important. In the best case the quality (still) rises and the processing time gets faster.

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 19, 2025

I tested it. Adding new videos shouldn't be a problem. For removing videos we'll need to recalculate the index and such and that will require more effort, and I'll leave that for someone really wants it.

Added in https://github.com/k4yt3x/video2x-qt6/tree/59644af2a3f73411b5dbeb1599fd837a08f82b6a

@k4yt3x k4yt3x closed this as completed Jan 19, 2025
@github-actions github-actions bot added state:Done This issue has been resolved/dismissed and removed state:Planned This issue is already scheduled to be worked on labels Jan 19, 2025
@k4yt3x
Copy link
Owner

k4yt3x commented Jan 19, 2025

@GautDlpr

if you're talking about the index of pending files, it's not wrong

The GUI uses an index named m_currentVideoIndex to keep track of the index of the video it is processing. Let's say you're processing the 3rd video, and you remove a video on top, the current video's index needs to be decremented from 2 to 1 and so on.

Since you can select multiple non-continuous videos, we'll need to do the math carefully to check which removals will need to decrement the the index, hence a bit more effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants