-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to add more files to the Processing Queue #1281
Comments
Yeah that'll be a nice-to-have. It'll just require more careful management of the objects.
I agree. It can be added relatively easily as a checkbox or combo box. |
You can already do this by dragging and dropping the new files to be processed during the current process, and it works very well. |
I have to try this again. |
OK, that seems to Work now. But the Checkbox is still a good idea |
@GautDlpr tbh that wasn't intended haha I didn't intend to allow adding more files on the fly because I'm afraid the index math will go wrong. I haven't really tested that functionality. I guess adding won't be too big of a deal, it's when autoremove is added will it require changes. |
@k4yt3x if you're talking about the index of pending files, it's not wrong (at least in the interface). If you're talking about another index, idk. One thing's for sure, though: if it's affected the quality of my processed files, I'm going to cry, because over the last few days I've been processing an insane number of videos, many of which have been added on the fly. I haven't done any quality check yet, but I'll let you know if I need to buy a big box of tissues 🥲. |
But I think it should be useful, when you are able to use the "REMOVE", "ADD" and "CLEAR" function for every processing file in the GUI, so that you can clear every file you want one after one. For that these functions shouldn't be in a grey out-status. Then adding the checkbox in the options, when you want every successful file to be removed. |
@GautDlpr Yes, it should not affect the quality or the processing time, that's important. In the best case the quality (still) rises and the processing time gets faster. |
I tested it. Adding new videos shouldn't be a problem. For removing videos we'll need to recalculate the index and such and that will require more effort, and I'll leave that for someone really wants it. Added in https://github.com/k4yt3x/video2x-qt6/tree/59644af2a3f73411b5dbeb1599fd837a08f82b6a |
The GUI uses an index named Since you can select multiple non-continuous videos, we'll need to do the math carefully to check which removals will need to decrement the the index, hence a bit more effort. |
It would be great to add more files to the Processing Queue without aborting a file in the whole Queue. Furthermore it would be great to choose an Option that finished files disappear from the Queue.
The text was updated successfully, but these errors were encountered: