Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade test container version #11996

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Mar 20, 2025

Proposed Changes

  • Updates image name transformation to be correct when more than one dash is present.
  • Bump timeouts for skew test, flaky on arm Drone CI, our slowest runner
  • Ensure proper cleanup of Docker containers for all docker tests (currently only half had proper cleanup checks). Should stop arm Drone runner from becoming unresponsive.

Types of Changes

Testing fixes

Verification

CI is green

Testing

Its all testing

Linked Issues

#11971

User-Facing Change


Further Comments

brandond
brandond previously approved these changes Mar 20, 2025
brandond
brandond previously approved these changes Mar 20, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>

Fix cleanup

Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
brandond previously approved these changes Mar 21, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.85%. Comparing base (76c5c77) to head (3c969f7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11996      +/-   ##
==========================================
+ Coverage   39.64%   44.85%   +5.21%     
==========================================
  Files         189      190       +1     
  Lines       19091    19105      +14     
==========================================
+ Hits         7568     8570    +1002     
+ Misses      10305     9291    -1014     
- Partials     1218     1244      +26     
Flag Coverage Δ
e2etests 35.75% <ø> (+1.18%) ⬆️
inttests 35.26% <ø> (?)
unittests 16.80% <ø> (+1.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matttrach matttrach merged commit 7837d29 into k3s-io:master Mar 21, 2025
54 checks passed
maxxieb pushed a commit to maxxieb/k3s that referenced this pull request Mar 22, 2025
* Fix upgrade test container version

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Ensure CI cleanup on all docker tests

Signed-off-by: Derek Nola <derek.nola@suse.com>

Fix cleanup

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Bump skew test timeout

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants