Fix e2e ingress IP helper #11729
Open
Fix e2e ingress IP helper #11729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
fix-e2e-ingress
branch
3 times, most recently
from
28bacf3 to
b9c7693
Compare
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-e2e-ingress
branch
from
b9c7693 to
dfbc372
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11729 +/- ##
==========================================
+ Coverage 44.78% 46.79% +2.00%
==========================================
Files 206 206
Lines 19519 19519
==========================================
+ Hits 8741 9133 +392
+ Misses 9455 9059 -396
- Partials 1323 1327 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix e2e ingress IP helper
Fix the helper to return an error if the ingress doesn't have any IPs yet, and add an Eventually in the test to avoid race condition. Just because the ingress has been deployed doesn't mean that traefik has sync'd it yet.
Types of Changes
e2e bugfix
Verification
Check CI
Testing
Linked Issues
User-Facing Change
Further Comments