Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Docker test on Github Actions arm64 runners #11705

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Feb 3, 2025

Proposed Changes

  • Build both arm64 and amd64 versions of k3s artifacts in GHA
  • Implement Docker Go Tests as a matrix of both Arm64 and Amd64 architectures.
  • Consolidate Drone tests down to only be PR for arm (32bit) and tagging events (for publishing).
  • Reduce failures for Skew and Upgrade tests on forks by moving away from git branch to a channel based flag (git history is too inconsistent on GHA runners and just source ./script/version.sh is easier)

Types of Changes

Testing Overhaul

Verification

CI is green
THIS ALL RUNS IN 5m 38s
image

Testing

Its all testing

Linked Issues

#11704

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner February 3, 2025 17:33
Compile go tests for both amd64 and arm64

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (f78769d) to head (2826094).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11705      +/-   ##
==========================================
- Coverage   49.89%   47.61%   -2.29%     
==========================================
  Files         185      185              
  Lines       19353    19353              
==========================================
- Hits         9656     9214     -442     
- Misses       8300     8804     +504     
+ Partials     1397     1335      -62     
Flag Coverage Δ
e2etests 40.33% <ø> (-3.80%) ⬇️
inttests 35.00% <ø> (-0.06%) ⬇️
unittests 17.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants