Remove local restriction for deferred node password validation #11646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restricting deferred node password validation to only requests from the local node is not possible without breaking split-role cluster cold start. There are too many cases where node password secrets may not yet be available due to the apiserver not being up. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
allow-deferred-etcd-only
branch
from
a37dc64 to
3e506ec
Compare
cwayne18
previously approved these changes
Jan 23, 2025
ShylajaDevadiga
previously approved these changes
Jan 23, 2025
Also add an ordinal to subtests so its easier to figure out which one is failing Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
dismissed stale reviews from ShylajaDevadiga and cwayne18
via
463af34
ShylajaDevadiga
approved these changes
Jan 23, 2025
cwayne18
approved these changes
Jan 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11646 +/- ##
==========================================
- Coverage 50.02% 47.71% -2.32%
==========================================
Files 185 185
Lines 19265 19262 -3
==========================================
- Hits 9637 9190 -447
- Misses 8236 8739 +503
+ Partials 1392 1333 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove local restriction for deferred node password validation
Restricting deferred node password validation to only requests from the local node is not possible without breaking split-role cluster cold start. There are too many cases where node password secrets may not yet be available due to the apiserver not being up.
This was added in response to https://github.com/rancher/security-team/issues/1097#issuecomment-2575374965 but turns out to not be something we can actually lock down without breaking things.
Types of Changes
regression fix
Verification
See linked issue
Testing
TODO - need to add a split-role test that mimics rancher's order of operations. For split-role clusters, rancher waits for all etcd nodes to start containerd, kubelet, and etcd before joining control-plane nodes.
Tracking this in: #11647
Linked Issues
User-Facing Change
Further Comments