Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to use automatic signature settings for commit signing #41

Open
nan-mu opened this issue Oct 25, 2024 · 3 comments
Open

[BUG] Unable to use automatic signature settings for commit signing #41

nan-mu opened this issue Oct 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@nan-mu
Copy link

nan-mu commented Oct 25, 2024

Describe the bug
This may be a bug or a feature request. I have used many tools similar to Git cz, and they all read commit.gpgSign=true and sign the commit accordingly. However, our tool does not; it even bypasses Git's commit signing check hook. In this sense, it doesn't work as expected.

To Reproduce
I am signing with an SSH key. According to this article, the signing works correctly when I run git commit or git commit -S manually.

Expected behavior
When I check with git show/log --show-signature, if the commit is properly signed, the output should display something like: Good "git" signature for my@email.com with RSA key SHA256:hash or something?

Screenshots
image

Environment

  • OS:

    • image
  • Version: Installed with cargo install, so the version should be v0.1.1.

Additional context

None

@nan-mu nan-mu added the bug Something isn't working label Oct 25, 2024
@nan-mu
Copy link
Author

nan-mu commented Oct 25, 2024

Of course, if you are a little busy, I might be able to take a look and submit a related PR this weekend.
And I noticed that the git-cz command does not have --version

@k3ii
Copy link
Owner

k3ii commented Nov 5, 2024

Hello @nan-mu , thank you for opening this issue.

We can support commit signing using git2-ext. Or if you know a better way, please submit a PR.

About the --version, we can use the crate clap for it.

@k3ii
Copy link
Owner

k3ii commented Nov 5, 2024

Here's a blog explaining how to do sign commits in Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants