Fixes a small potential bug on headless switch component #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `click`-event is now correctly handled by stop propagating it and `preventDefault` as the headless component will do all the work. This could have led to bugs when using the component with explicit `DataBinging`, where the `handler`-lambda would be used to intercept the update call.
Lysander
added
bug
haukesomm
approved these changes
Jan 31, 2025
Lysander
added a commit
that referenced
this pull request
Jan 31, 2025
The `click`-event is now correctly handled by stop propagating it and `preventDefault` as the headless component will do all the work. This could have led to bugs when using the component with explicit `DataBinging`, where the `handler`-lambda would be used to intercept the update call. Co-authored-by: christian.hausknecht <christian.hausknecht@oeffentliche.de> (cherry picked from commit b20fd4d)
Lysander
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
click-event is now correctly handled by stop propagating it andpreventDefaultas the headless component will do all the work.This could have led to bugs when using the component with explicit
DataBinging, where thehandler-lambda would be used to intercept the update call.