Stop propagation of combobox keyboard events #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to make it clear: The intent is really to stop propagations upwards the DOM hierarchy and not immediately? (which would have been |
|
I see, this was my bad. Actually, the intent is to stop any other handler from handling the event. So |
This commit adds a missing `stopPropagation` call in the combobox's keyboard event handling in order to prevent those events from bubbling to other elements.
haukesomm
force-pushed
the
haukesomm/combobox-propagation
branch
from
19213aa to
b307b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing
stopPropagationcall in the combobox's keyboard event handling in order to prevent those events from bubbling to other elements.