Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken references #923

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Update broken references #923

merged 3 commits into from
Nov 20, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

Commit fdbf998 renamed bunch of Java files. This PR adjusts sources to changes.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Copy link
Collaborator

@haukesomm haukesomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing! Everything looks good here, approved

@haukesomm haukesomm added this to the 1.0-RC20 milestone Nov 19, 2024
@haukesomm haukesomm added the documentation Improvements or additions to documentation label Nov 19, 2024
Copy link
Collaborator

@haukesomm haukesomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's me again, I'm sorry to revoke my approval but there is one more referenace in the documentation/blog that seems to be broken:

  • www/src/blog/posts/paradigm-shift-for-components.md, line 266
    • https://github.com/jwstegemann/fritz2/blob/master/headless-demo/src/jsMain/kotlin/dev/fritz2/headlessdemo/radioGroup.kt

Would you mind fixing that one as well? this way, we can avoid another PR for just one line of code 😄

Thanks!

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman
Copy link
Contributor Author

@haukesomm sure thing, please let me know if anything else is needed from my side 😄

Copy link
Collaborator

@haukesomm haukesomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tranks, everything Looks good once again!

@haukesomm haukesomm merged commit 94ea2ad into jwstegemann:master Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants